-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:make fsnotify event more readable #22903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Jan 2, 2023
github-actions
bot
added
the
kind/community-contribution
This was a contribution made by a community member.
label
Jan 2, 2023
YutaroHayakawa
added
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
kind/cleanup
This includes no functional changes.
release-note/misc
This PR makes changes that have no direct user impact.
labels
Jan 4, 2023
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Jan 4, 2023
YutaroHayakawa
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldelossa
approved these changes
Jan 6, 2023
@yulng can you rebase this branch on latest master? Thanks. |
Signed-off-by: yulng <wei.yang@daocloud.io>
rebase it and push again just now |
/test |
1 similar comment
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 9, 2023
jschwinger233
added a commit
to jschwinger233/cilium
that referenced
this pull request
Aug 25, 2023
This reverts commit 479fb7d. The code changes are not equivalent. For example, event.Op=fsnotify.Create has different results. Fixes: cilium#22903 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
This pull request was reverted in #27694 because it introduced a regression in IPsec key rotations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/cleanup
This includes no functional changes.
kind/community-contribution
This was a contribution made by a community member.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
sig/datapath
Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yulng wei.yang@daocloud.io
fsnotify/fsnotify#477 and fsnotify release .
so to make fsnotify event more readable
Thanks